Build the RID-specific System.IO.Ports packages in the VMR#112054
Build the RID-specific System.IO.Ports packages in the VMR#112054jkoritzinsky merged 1 commit intodotnet:mainfrom
Conversation
ghost
added
the
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries |
I'm not fully following. Can you please provide more details on how this regressed? This would help me better understand the proposed fix. |
|
When I added DotNetBuildAllRuntimePacks, I found I needed to handle the configuration of "what if you set that and pass -pack" vs "what if you don't set that and don't pass -pack", etc. And the condition didn't do what I wanted to do in the VMR (which does set that property and pass -pack). |
* main: System.Net.Http.WinHttpHandler.StartRequestAsync assertion failed (dotnet#109799) Keep test PDB in helix payload for native AOT (dotnet#111949) Build the RID-specific System.IO.Ports packages in the VMR (dotnet#112054) Always inline number conversions (dotnet#112061) Use Contains{Any} in Regex source generator (dotnet#112065) Update dependencies from https://github.com/dotnet/arcade build 20250130.5 (dotnet#112013) JIT: Transform single-reg args to FIELD_LIST in physical promotion (dotnet#111590) Ensure that math calls into the CRT are tracked as needing vzeroupper (dotnet#112011) Use double.ConvertToIntegerNative where safe to do in System.Random (dotnet#112046) JIT: Compute `fgCalledCount` after synthesis (dotnet#112041) Simplify boolean logic in `TimeZoneInfo` (dotnet#112062) JIT: Update type when return temp is freshly created (dotnet#111948) Remove unused build controls and simplify DotNetBuild.props (dotnet#111986) Fix case-insensitive JSON deserialization of enum member names (dotnet#112028) WasmAppBuilder: Remove double computation of a value (dotnet#112047) Disable LTCG for brotli and zlibng. (dotnet#111805) JIT: Improve x86 unsigned to floating cast codegen (dotnet#111595) simplify x86 special intrinsic imports (dotnet#111836) JIT: Try to retain entry weight during profile synthesis (dotnet#111971) Fix explicit offset of ByRefLike fields. (dotnet#111584)
2 participants
The RID-specific System.IO.Ports packages weren't getting produced in the VMR once we did the build leg reduction as the VMR sets both
BuildAllConfigurationsandDotNetBuildAllRuntimePacks. Refactor how we calculate the condition and explicitly enable the packages in the VMR.