__ComObject doesn't support dynamic interface map#112375
Merged
AaronRobinsonMSFT merged 2 commits intodotnet:mainfrom Feb 12, 2025
Merged
__ComObject doesn't support dynamic interface map#112375AaronRobinsonMSFT merged 2 commits intodotnet:mainfrom
__ComObject doesn't support dynamic interface map#112375AaronRobinsonMSFT merged 2 commits intodotnet:mainfrom
Conversation
In dotnet#105965, an interface was added to __ComObject. This made some previous checks fail as they were written assuming __ComObject didn't have any interfaces.
elinor-fung
approved these changes
Feb 10, 2025
Member
elinor-fung
left a comment
elinor-fung
left a comment
There was a problem hiding this comment.
Is this something one of our COM tests should have caught? The repro seems like it was failing on a basic scenario of passing out a COM interface.
jkoritzinsky
approved these changes
Feb 10, 2025
Member
Author
Yes, we were missing a test case. Added now. |
grendello
added a commit
to grendello/runtime
that referenced
this pull request
Feb 12, 2025
* main: [Android] Run CoreCLR functional tests on Android (dotnet#112283) [LoongArch64] Fix some assertion failures for Debug ILC building Debug NativeAOT testcases. (dotnet#112229) Fix suspicious code fragments (dotnet#112384) `__ComObject` doesn't support dynamic interface map (dotnet#112375) Native DLLs: only load imported DLLs from System32 (dotnet#112359) [main] Update dependencies from dotnet/roslyn (dotnet#112314) Update SVE instructions that writes to GC regs (dotnet#112389) Bring up android+coreclr windows build. (dotnet#112256) Never use heap for return buffers (dotnet#112060) Wait to complete the test before releasing the agile reference. (dotnet#112387) Prevent returning disposed HTTP/1.1 connections to the pool (dotnet#112383) Fingerprint dotnet.js if writing import map to html is enabled (dotnet#112407) Remove duplicate definition of CORECLR_HOSTING_API_LINKAGE (dotnet#112096) Update the exception message to reflect current behavior. (dotnet#112355) Use enum for frametype not v table (dotnet#112166) Enable AltJits build for LoongArch64 and RiscV64 (dotnet#110282) Guard members of MonoType union & fix related bugs (dotnet#111645) Add optional hooks for debugging OpenSSL memory allocations (dotnet#111539) JIT: Optimize struct parameter register accesses in the backend (dotnet#110819) NativeAOT: Cover more opcodes in type preinitializer (dotnet#112073)
This was referenced Feb 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #105965, an interface was added to
__ComObject. This made some previous checks fail as they were written assuming__ComObjectdidn't have any interfaces. This change makes an explicit check that theMethodTablebeing queried isn't__ComObjectas opposed to relying on some indirect reasoning.Fixes #112371