[release/9.0-staging] [Apple mobile] Enable trimming on build machines to match ILLink features#113466
Merged
kotlarmilos merged 3 commits intodotnet:release/9.0-stagingfrom Apr 3, 2025
Conversation
…ures (dotnet#110966) Trimming is now moved trimming from Helix to AzDo (build) machines. Redundant code for maintaining ILLink features is removed.
kotlarmilos
requested review from
ivanpovazan and
matouskozak
and removed request for
Copilot,
ivanpovazan and
marek-safar
ghost
added
the
kotlarmilos
added
area-Infrastructure-mono
os-ios
Contributor
|
Tagging subscribers to this area: @akoeplinger, @matouskozak |
Contributor
|
Tagging subscribers to 'os-ios': @vitek-karas, @kotlarmilos, @ivanpovazan, @steveisok, @akoeplinger |
ivanpovazan
approved these changes
Mar 13, 2025
matouskozak
approved these changes
Mar 13, 2025
Member
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jeffschwMSFT
approved these changes
Mar 19, 2025
Member
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
approved. we can treat this as tell mode.
jeffschwMSFT
added
Servicing-approved
Member
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Mar 31, 2025
Contributor
|
Friendly reminder that code complete is on April 14th for the May Release. If you'd like to get this change included in that release, please merge this PR before that date. |
Member
Author
|
/ba-g wasm timeouts |
kotlarmilos
added
Servicing-approved
kotlarmilos
merged commit bbf23a2
into
dotnet:release/9.0-staging
193 of 199 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #110966 to release/9.0-staging
Customer Impact
This PR moves trimming from Helix to AzDo (build) machines to simplify ILLink feature alignment between AzDo and Helix. Previously, when an ILLink feature was added to the SDK, we needed to manually maintain an internal setup. This change should resolve Apple mobile test failures on extra-platforms.
Regression
This is an infrastructure improvement that fixes failing tests.
Testing
Library tests on extra-platforms and ioslike pipelines.
Risk
Low. This change does not affect the shipping code.
IMPORTANT: If this backport is for a servicing release, please verify that:
release/X.0-staging, notrelease/X.0.Package authoring no longer needed in .NET 9
IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.