Disable some named synchronization object tests on Windows Server Core#113482
Merged
MichalStrehovsky merged 1 commit intodotnet:mainfrom Mar 14, 2025
kouvel:FixTests
Merged
Disable some named synchronization object tests on Windows Server Core#113482MichalStrehovsky merged 1 commit intodotnet:mainfrom kouvel:FixTests
MichalStrehovsky merged 1 commit intodotnet:mainfrom
kouvel:FixTests
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the conditional test attributes to disable named synchronization object tests on Windows Server Core, in response to the observed behavior that Windows Server Core uses the same namespace for local and global objects.
- Updated conditional attributes in EventWaitHandleTests.cs, MutexTests.cs, and SemaphoreTests.cs to use PlatformDetection.IsNotWindowsNanoNorServerCore.
- Adjusted inline comments to reflect the inclusion of Server Core in the exclusion criteria.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/libraries/System.Threading/tests/EventWaitHandleTests.cs | Updated conditional attribute and comment for Windows Server Core. |
| src/libraries/System.Threading/tests/MutexTests.cs | Updated conditional attribute and comment for Windows Server Core. |
| src/libraries/System.Threading/tests/SemaphoreTests.cs | Updated conditional attribute and comment for Windows Server Core. |
Contributor
|
Tagging subscribers to this area: @mangod9 |
Contributor
Author
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Mar 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new failing tests were added in #112213. It looks like Windows Server Core also does not use different namespaces for local and global named synchronization objects.