Revert "Don't use incompatible LOAD_LIBRARY_SEARCH flags when using LOAD_WITH_ALTERED_SEARCH_PATH"

[jkotas]

Reverts #111990

[Copilot]

Copilot reviewed 6 out of 9 changed files in this pull request and generated no comments.

Files not reviewed (3)

• src/tests/Interop/CMakeLists.txt: Language not supported
• src/tests/Interop/DllImportSearchPaths/DllImportSearchPathsTest.csproj: Language not supported
• src/tests/Interop/DllImportSearchPaths/NativeLibraryWithDependency/CMakeLists.txt: Language not supported

Comments suppressed due to low confidence (3)

src/coreclr/vm/nativelibrary.cpp:478

• Removal of the assertion checking that the path is not relative may allow unintended relative path usage. Please verify that path validation is performed elsewhere to avoid potential loading issues.

_ASSERTE(!Path::IsRelative(path));

src/tests/Interop/DllImportSearchPaths/DllImportSearchPathsTest.cs:67

• The test method 'AssemblyDirectory_SearchFlags_WithDependency_Found' has been removed, which might reduce test coverage for dependency loading via the assembly directory. Consider ensuring equivalent coverage exists or reintroducing a minimal test.

[ConditionalFact(nameof(CanLoadAssemblyInSubdirectory))]

src/mono/mono/metadata/native-library.c:355

• Reverting the flag adjustment by removing the call to add_load_with_altered_search_path_flags may impact the handling of search flags on Windows. Please confirm that the new flag logic correctly supports all expected behaviors.

module = netcore_probe_for_module_variations (mdirname, file_name, lflags, error);

[dotnet-policy-service]

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

[jkotas]

#111990 (comment)