Do not rethrow from SocketsTestServerAPM.OnAccept#114964
Merged
rzikm merged 3 commits intodotnet:mainfrom Apr 25, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issue #85666 by preventing rethrows in the SocketTestServerAPM.OnAccept method to avoid test process crashes.
- Removed rethrows from two SocketException catch blocks
- Simplified exception handling to ensure the recursive OnAccept loop exits gracefully
Comments suppressed due to low confidence (2)
src/libraries/Common/tests/System/Net/Sockets/SocketTestServerAPM.cs:54
- Consider adding a comment in this catch block to explain that swallowing the exception is intentional to prevent process crashes during continuous accepts.
throw;
src/libraries/Common/tests/System/Net/Sockets/SocketTestServerAPM.cs:78
- Consider adding a comment in this catch block to clarify that omitting the rethrow is intentional as part of the fix for test process crashes.
throw;
MihaZupan
approved these changes
Apr 23, 2025
src/libraries/Common/tests/System/Net/Sockets/SocketTestServerAPM.cs
Outdated
Show resolved
Hide resolved
…APM.cs Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
antonfirsov
approved these changes
Apr 23, 2025
rzikm
commented
Apr 24, 2025
src/libraries/Common/tests/System/Net/Sockets/SocketTestServerAPM.cs
Outdated
Show resolved
Hide resolved
This was referenced Apr 24, 2025
Member
Author
|
/ba-g test failure is #115006 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #85666.
The test class spawns a recursive OnAccept method which uses Begin/End pattern to continue accepting connections until the server is disposed. There is a condition which allows SocketException with SocketError.InvalidArgument to be thrown out of the function which leads to test process crash.
Since any sort of exception would crash the process, this PR simplifies the logic by removing any rethrows.