Merged
Conversation
ghost
added
the
needs-area-label
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the MacOS code-signing pipeline configuration to use a PME identity in line with recent security requirements.
- Updates service connection and authentication configuration
- Switches from certificate-based authentication to MSI-based authentication
- Replaces existing client and tenant identifiers with PME-specific values
Comments suppressed due to low confidence (2)
eng/pipelines/common/macos-sign-with-entitlements.yml:32
- The removal of the 'AuthCertName' parameter appears to be a deliberate change for MSI-based authentication; please confirm that no parts of the pipeline depend on certificate-based authentication.
- AuthCertName: 'DotNetCore-ESRP-AuthCert'
eng/pipelines/common/macos-sign-with-entitlements.yml:34
- Ensure that switching to MSI authentication and updating related client IDs align with the PME requirements and that all dependent processes are adjusted accordingly.
+ UseMSIAuthentication: true
hoyosjs
approved these changes
May 6, 2025
This was referenced May 6, 2025
Member
|
/ba-g continued OOMs from crypto tests - unrelated to PME portion that doesn't get exercised in CI. |
Member
|
/backport to release/8.0-staging |
Contributor
|
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/15057412876 |
Member
|
/backport to release/8.0 |
Member
|
/backport to release/9.0 |
Contributor
|
Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/15057416852 |
Contributor
|
Started backporting to release/9.0: https://github.com/dotnet/runtime/actions/runs/15057417574 |
This was referenced May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to dotnet/arcade-services#4611
Updates the MacOS signing to use a PME identity in accordance with a corresponding TSG
dotnet-runtime-officialbuild: https://dev.azure.com/dnceng/internal/_build/results?buildId=2702879&view=resultsExample of the identity being used for publishing: https://dev.azure.com/dnceng/internal/_build/results?buildId=2702156&view=results