Conversation
Delete comments that refer to the old Windows-specific profiler attach implementation that was deleted by dotnet/coreclr#24670
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes obsolete comments that reference the old Windows-specific profiler attach implementation. The changes simplify the code by eliminating outdated documentation that is no longer relevant.
- Removed an outdated comment block in profilinghelper.cpp detailing old initialization assumptions.
- Deleted a similar obsolete comment block in profdetach.cpp.
- Updated comments in finalizerthread.cpp to remove references to deprecated profiler attach behavior.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/coreclr/vm/profilinghelper.cpp | Removed obsolete comments regarding old profiler attach assumptions. |
| src/coreclr/vm/profdetach.cpp | Deleted outdated comment section related to profiling attach/detach. |
| src/coreclr/vm/finalizerthread.cpp | Updated comments by removing references to deprecated profiler attach. |
Contributor
|
Tagging subscribers to this area: @mangod9 |
mangod9
approved these changes
May 18, 2025
Member
Author
|
/ba-g infrastructure timeouts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delete comments that refer to the old Windows-specific profiler attach implementation that was deleted by dotnet/coreclr#24670