SVE2 API for MaxNumberPairwise, MaxPairwise, MinNumberPairwise and MinPairwise#117711
Merged
amanasifkhalid merged 2 commits intodotnet:mainfrom Jul 18, 2025
Merged
SVE2 API for MaxNumberPairwise, MaxPairwise, MinNumberPairwise and MinPairwise#117711amanasifkhalid merged 2 commits intodotnet:mainfrom
amanasifkhalid merged 2 commits intodotnet:mainfrom
Conversation
dotnet-policy-service
bot
added
the
community-contribution
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics |
Contributor
amanasifkhalid
left a comment
amanasifkhalid
left a comment
There was a problem hiding this comment.
LGTM, I'll do another pass once the merge conflicts are resolved
jacob-crawley
force-pushed
the
sve2-pairwise
branch
from
7efb3a2 to
3d7e9ac
Compare
amanasifkhalid
approved these changes
Jul 16, 2025
amanasifkhalid
suggested changes
Jul 16, 2025
Contributor
amanasifkhalid
left a comment
amanasifkhalid
left a comment
There was a problem hiding this comment.
@jacob-crawley there are some test failures to sort through:
Sve2.MaxPairwise<Byte>(Vector<Byte>, Vector<Byte>): ConditionalSelectScenario_TrueValue failed:
mask: (1, 1, 0, 1, 1, 1, 0, 1, 1, 1, 1, 0, 0, 1, 1, 0)
left: (166, 253, 151, 253, 158, 255, 68, 231, 161, 217, 94, 114, 194, 112, 48, 190)
right: (85, 244, 208, 130, 155, 80, 85, 246, 138, 36, 77, 89, 66, 48, 199, 13)
falseOp: (0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0)
result: (253, 244, 0, 208, 255, 155, 0, 246, 217, 138, 94, 0, 0, 66, 48, 0)
This was referenced Jul 16, 2025
auto-merge was automatically disabled
July 17, 2025 15:37
Head branch was pushed to by a user without write access
jacob-crawley
force-pushed
the
sve2-pairwise
branch
from
3d7e9ac to
308e8a1
Compare
amanasifkhalid
approved these changes
Jul 17, 2025
Contributor
amanasifkhalid
left a comment
amanasifkhalid
left a comment
There was a problem hiding this comment.
Thanks for the fix
Contributor
|
/ba-g build timeouts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@dotnet/arm64-contrib @amanasifkhalid @a74nh
Contributing towards #115479