Merged
Conversation
|
@dotnet/samsung Could you please take a look? These changes may be related to riscv64. |
This was referenced Jul 25, 2025
Contributor
|
Tagging subscribers to this area: @steveisok, @dotnet/dotnet-diag |
noahfalk
reviewed
Jul 29, 2025
jkotas
reviewed
Jul 31, 2025
This was referenced Aug 12, 2025
This was referenced Aug 13, 2025
max-charlamb
commented
Aug 13, 2025
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader/ContractDescriptorParser.cs
Show resolved
Hide resolved
noahfalk
reviewed
Aug 13, 2025
Member
noahfalk
left a comment
There was a problem hiding this comment.
This looked fine to me but we should go over it with Maoni as well.
max-charlamb
commented
Aug 20, 2025
mangod9
reviewed
Aug 25, 2025
mangod9
reviewed
Aug 25, 2025
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/GC_1.cs
Show resolved
Hide resolved
Member
|
GC side changes look good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements and adds sub-descriptor as defined by #118126 for the GC. Each variation of the GC (SVR/WKS) has its own descriptor which is set up in
PopulateDacVars.Changes
sub-descriptorsindatadescriptor.cppandcdac-build-toolsrc/coreclr/gc/datadescriptormirroring the vm descriptors undersrc/coreclr/vm/datadescriptor.gcinterfaceminor version to support adding new fieldgc_descriptorNotes
In order to test the new GC descriptor, implements
ISOSDacInterface::GetGCHeapDataandISOSDacInterface::GetGCHeapList.cdac_dataspecializations outside of the GC namespace (indatadescriptor.h). In theory we could move this into the GC namespace, but this conflicts with the existing definition used in the global namespace in coreclr. I thought reusing the same class and moving the specializations was reasonable.There are several times the GC is built without datadescriptors (or where they aren't supported). These include NativeAOT (something in bootstrap builds) andsrc/coreclr/gc/sample. We most likely need#ifdefout the extern specifiers in these scenarios.GC_DESCRIPTORdefine for builds when we expect the GCDescriptor.Currently waiting on updating coreclr to target c++17 Proposal: Upgrade C++ compiler feature level to C++ 17 #112419 to resolve build issues.