Update DefaultStackSize to Thread_DefaultStackSize#118076
Merged
MichalStrehovsky merged 1 commit intomainfrom Jul 29, 2025
Merged
Update DefaultStackSize to Thread_DefaultStackSize#118076MichalStrehovsky merged 1 commit intomainfrom
MichalStrehovsky merged 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates a configuration key name from "DefaultStackSize" to "Thread_DefaultStackSize" in the CoreCLR PAL initialization code. This change aligns the configuration key name with a more descriptive and standardized naming convention that explicitly indicates it controls the default stack size for threads.
Key changes:
- Updates the CLRConfigNoCache configuration key retrieval to use the new "Thread_DefaultStackSize" name
jkotas
approved these changes
Jul 25, 2025
AaronRobinsonMSFT
approved these changes
Jul 26, 2025
MichalStrehovsky
added a commit
that referenced
this pull request
Jul 29, 2025
This reverts commit a8fee60.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#110455 (comment)