Add more info for StdErrAfter assertion in host tests#118712
Merged
elinor-fung merged 2 commits intodotnet:mainfrom Aug 15, 2025
Merged
Add more info for StdErrAfter assertion in host tests#118712elinor-fung merged 2 commits intodotnet:mainfrom
elinor-fung merged 2 commits intodotnet:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the test infrastructure for host tests by improving the diagnostics information provided when StdErr assertions fail. Instead of only showing stderr output, it now provides comprehensive command execution details including file name, arguments, environment variables, exit code, and both stdout and stderr.
- Moves
GetDiagnosticsInfo()method fromCommandResultAssertionstoCommandResultclass for better encapsulation - Updates assertion error messages to use the enhanced diagnostics information
- Filters environment variables to show DOTNET_ prefixed variables instead of just DOTNET_ROOT
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/installer/tests/TestUtils/CommandResult.cs | Adds GetDiagnosticsInfo() method to provide comprehensive command execution details |
| src/installer/tests/TestUtils/Assertions/CommandResultExtensions.cs | Updates StdErr assertion error message to use new diagnostics info |
| src/installer/tests/TestUtils/Assertions/CommandResultAssertions.cs | Removes GetDiagnosticsInfo() method and delegates to CommandResult implementation |
Contributor
|
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov |
AaronRobinsonMSFT
approved these changes
Aug 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The assertion only ended up printing stderr, but it would be useful to have all the information about the command that was run (the exit code, stdout). Without it, we have no insight into issues like #118170, especially since it does not seem to repro easily (first time we've seen it, hasn't been hit again).
Resolves #118170 - while this wouldn't actually fix whatever happened there, it will give us insight into any similar issues that happen again.
cc @dotnet/appmodel @AaronRobinsonMSFT