[cDAC] implement GetGCHeapDetails and GetGCHeapStaticData#119119
Merged
max-charlamb merged 11 commits intodotnet:mainfrom Sep 3, 2025
Merged
[cDAC] implement GetGCHeapDetails and GetGCHeapStaticData#119119max-charlamb merged 11 commits intodotnet:mainfrom
max-charlamb merged 11 commits intodotnet:mainfrom
Conversation
Contributor
|
Tagging subscribers to this area: @steveisok, @dotnet/dotnet-diag |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements two new cDAC methods for retrieving GC heap details: GetGCHeapDetails for server mode GC and GetGCHeapStaticData for workstation mode GC. The implementation replaces placeholder methods with full functionality that extracts comprehensive GC heap information including generation tables, finalization data, and various heap-specific pointers.
Key changes:
- Adds complete implementations for
ISOSDacInterface.GetGCHeapDetailsandISOSDacInterface.GetGCHeapStaticData - Introduces new data contracts and structures for accessing GC heap data from both workstation and server GC configurations
- Extends the GC contract with new APIs for retrieving heap bounds, GC state, and detailed heap data
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
SOSDacImpl.cs |
Implements GetGCHeapDetails and GetGCHeapStaticData with comprehensive GC heap data extraction and debug validation |
ISOSDacInterface.cs |
Adds GCConstants, DacpGenerationData, and DacpGcHeapDetails structures with updated method signatures |
Generation.cs |
New data contract for accessing GC generation information including allocation context and segment data |
GCHeap.cs |
New data contract for server GC heap access with comprehensive heap field mapping |
CFinalize.cs |
New data contract for accessing finalization queue fill pointers |
GC_1.cs |
Extends GC contract with heap data retrieval methods for both workstation and server modes |
Constants.cs |
Adds global pointer constants for GC heap field access |
DataType.cs |
Registers new GC-related data types |
IGC.cs |
Defines new heap data structures and extends IGC interface with heap access APIs |
datadescriptor.inc (vm) |
Adds GC address bound globals |
gcpriv.h |
Adds friend declaration for CFinalize cdac_data access |
gc.cpp |
Fixes background GC build variant flag logic |
datadescriptor.inc (gc) |
Comprehensive GC data structure definitions for heap, generation, and finalization data |
datadescriptor.h |
Adds cdac_data specializations for gc_heap and CFinalize types |
GC.md |
Updates documentation with new GC contract APIs and data structures |
3 tasks
mangod9
approved these changes
Sep 2, 2025
32 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.