Allow using ld_classic if requested#119408
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the MSBuild targets that prevented manual enablement of the ld_classic linker when using Xcode versions greater than 15. The fix allows users to explicitly set the UseLdClassicXCodeLinker property to true to force the use of ld_classic regardless of Xcode version.
- Modifies the condition for adding the
-ld_classiclinker argument to respect explicit user configuration - Maintains backward compatibility by preserving the automatic behavior for Xcode 15
src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targets
Outdated
Show resolved
Hide resolved
|
Should we instead extend the xcode version check? If I understand this correctly, we default to ld_classic on xcode 15 (with an opt out) because that version has problem. We now know xcode 16 also has problems. Should we just default to ld_classic too? |
…e.Unix.targets Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
I've taken this advice and included 16 in the version check. I believe 26 actually fixes many of the bugs we're seeing in 16. |
|
/ba-g dead letter |
It looks like there's a small bug in our targets that doesn't allow directly enabling ld_classic through an msbuild property if the XCode version is > 15.