Merge throw blocks in fgHeadTailMerge#122070
Merged
EgorBo merged 3 commits intodotnet:mainfrom Dec 2, 2025
Merged
Conversation
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the tail merge optimization in fgHeadTailMerge to handle BBJ_THROW blocks in addition to BBJ_RETURN blocks. The change allows the JIT compiler to merge common tail statements from throw blocks, which should fix a regression introduced in a previous PR.
Key Changes
- Modified the block kind check to include both
BBJ_RETURNandBBJ_THROWblocks for tail merge consideration - This enables tail merging optimization to work on throw blocks, similar to how it already works on return blocks
Member
Author
|
PTAL @dotnet/jit-contrib Diffs |
AndyAyersMS
reviewed
Dec 1, 2025
AndyAyersMS
approved these changes
Dec 1, 2025
This was referenced Dec 1, 2025
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix the regression in #122065
Diffs