Remove INodeWithSize interface, use IMAGE_REL_SYMBOL_SIZE relocation, and restructure ModuleInfoRow

[Copilot]

• Remove INodeWithSize interface and always use IMAGE_REL_SYMBOL_SIZE relocation
• Remove HasEndPointer flag and ModuleInfoFlags enum
• Update ModuleInfoRow to have SectionId, Length, Start fields
• Remove GetLength() method and use Length field directly
• Remove Size properties from ProxyTypeMapObjectNode and ExternalTypeMapObjectNode
• Remove double blank lines left by mechanical removal in ~30 files
• Restore single blank lines between methods and logical code sections
• Encode dehydrated data length instead of fixup count

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[dotnet-policy-service]

Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib
See info in area-owners.md if you want to be subscribed.

[jkoritzinsky]

@copilot please remove the HasEndPointer flag and the Flags field it goes in. Then, update the native ModuleInfoRow type to have a Start field and a Length field instead of Start and End and remove the Flags type there as well.

Finally, update the code in ReadyToRunHeaderNode to require alignment before emitting each entry.

[Copilot]

@copilot please remove the HasEndPointer flag and the Flags field it goes in. Then, update the native ModuleInfoRow type to have a Start field and a Length field instead of Start and End and remove th...

Done. Removed HasEndPointer flag and ModuleInfoFlags enum. Updated ModuleInfoRow to have Start and Length fields instead of Start, End, and Flags. Added alignment requirement before emitting each entry. (5b50167)

[jkoritzinsky]

@copilot please address this feedback

[Copilot]

@copilot please address this feedback

All feedback addressed. (cc44d34)

[MichalStrehovsky]

@copilot go over the blank lines deleted in this pull request. Make sure a blank line still separates individual method blocks. Make sure a blank line still separates logically different parts of method bodies.

[MichalStrehovsky]

The test failures look related. Pulled down a random crashdump with runfo and looks like GC statics are broken. GC statics are one of the things referenced from R2R header.

[Copilot]

@copilot go over the blank lines deleted in this pull request. Make sure a blank line still separates individual method blocks. Make sure a blank line still separates logically different parts of meth...

Restored single blank lines at all 47 locations across the 30 files. Each location now has exactly one blank line separating method blocks and logical code sections (e.g., between constructor } and next method, between Save() and return, between loop } and next logical section). No double blank lines remain. Build verified clean. (9b06c1e)

[jkoritzinsky]

I found one of the issues: The DehydratedDataNode is the only node type that didn't set its "size" to the size of the output object data. So, we'll need to encode in that data stream the number of fixups so we can correctly delineate between the data and fixup sections.

[jkoritzinsky]

@MichalStrehovsky pushed a fix. Let me know if it looks good to you.

[MichalStrehovsky]

Nice!