Feedback from 3.1 amd64InstrDecode review#35670
Merged
sdmaclea merged 3 commits intodotnet:masterfrom Apr 30, 2020
Merged
Conversation
|
Tagging subscribers to this area: @tommcdon |
jkotas
reviewed
Apr 30, 2020
src/coreclr/src/debug/ee/amd64/gen_amd64InstrDecode/Amd64InstructionTableGenerator.csproj
Outdated
Show resolved
Hide resolved
jkotas
approved these changes
Apr 30, 2020
|
Hello @sdmaclea! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
sdmaclea
added a commit
to sdmaclea/coreclr
that referenced
this pull request
May 1, 2020
+ Typos (dotnet#26968) + Feedback from 3.1 amd64InstrDecode review (dotnet/runtime#35670)
Anipik
pushed a commit
to dotnet/coreclr
that referenced
this pull request
Jun 9, 2020
…28033) * Whitespace (#25957) * Modify amd64walker to use table based decode (#25958) * Modify amd64walker to use table based decode Use tables for NativeWalker::DecodeInstructionForPatchSkip() Also files used to generate the decode tables in doc folder. * Review feedback and typos + Typos (#26968) + Feedback from 3.1 amd64InstrDecode review (dotnet/runtime#35670)
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.