Remove an unnecessary check from fgMakeOutgoingStructArgCopy.#35701
Merged
erozenfeld merged 1 commit intodotnet:masterfrom May 1, 2020
Merged
Remove an unnecessary check from fgMakeOutgoingStructArgCopy.#35701erozenfeld merged 1 commit intodotnet:masterfrom
erozenfeld merged 1 commit intodotnet:masterfrom
Conversation
The old-style helper tail calls required the jit to copy implicit by-ref args. After dotnet#341 we are using old-style helper tail calls only for x86, which doesn't have implicit by-ref parameters. So the check is no longer necessary. This is a no-diffs cleanup change.
Dotnet-GitSync-Bot
added
the
area-CodeGen-coreclr
Member
Author
|
@dotnet/jit-contrib @AndyAyersMS PTAL |
Member
|
We might see some diffs in tests, though perhaps we don't have coverage for this case. Would need win x64, explicit tail calls that require helpers, and pass through implicit by ref structs. Maybe the code from #2191? |
AndyAyersMS
approved these changes
May 1, 2020
Member
Author
|
No, we won't see diffs from this change. IsTailCallViaJitHelper can only return true on x86. We could see the diffs you are thinking about from #341. This change is purely cleanup. |
Member
|
Ah, right, I had forgotten we refined this predicate to just cover the x86 helper case. |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old-style helper tail calls required the jit to copy implicit by-ref
args. After #341 we are using old-style helper tail calls only for x86,
which doesn't have implicit by-ref parameters. So the check is no longer
necessary.
This is a no-diffs cleanup change.