Remove WinRT specific code from EventSource.#37508
Merged
2 commits merged intodotnet:masterfrom Jun 6, 2020
Merged
Conversation
|
Tagging subscribers to this area: @ViktorHofer |
Member
|
You will also want to get rid of the It was added to provide a mechanism for |
brianrob
approved these changes
Jun 5, 2020
|
Hello @eerhardt! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we no longer have WinRT specific code in the runtime, we don't need these build defines in the EventSource code. No one is setting these defines, and it is confusing when looking at the code what types are public and what aren't.
Follow up to #36715
cc @brianrob