Fix crossgen2 incorrect handling of ldftn to external managed methods#38236
Merged
davidwrighton merged 5 commits intodotnet:masterfrom Jun 24, 2020
Merged
Fix crossgen2 incorrect handling of ldftn to external managed methods#38236davidwrighton merged 5 commits intodotnet:masterfrom
davidwrighton merged 5 commits intodotnet:masterfrom
Conversation
- Use existing Precode/Local import split - Remove special casing of ExternalMethodImport
Member
Author
|
@dotnet/crossgen-contrib |
trylek
approved these changes
Jun 22, 2020
Member
trylek
left a comment
There was a problem hiding this comment.
Looks great, thanks David for setting this right! I also appreciate your diligence in adding tons of new tests everywhere you hit a snag :-).
Contributor
|
Perhaps we can close this one when this is done? #13395 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue in crossgen2 where external managed methods which are used as part of an ldftn instruction are referred to through a delay load import instead of a precode import.
The issue was that the special handling of external methods as a seperate import type stepped around the handling of external methods via precode or delay load.
This change