Removed HttpClientHandler dead code and folded .Core file.#38408
Merged
stephentoub merged 1 commit intodotnet:masterfrom Jun 25, 2020
Merged
Removed HttpClientHandler dead code and folded .Core file.#38408stephentoub merged 1 commit intodotnet:masterfrom
stephentoub merged 1 commit intodotnet:masterfrom
Conversation
Collaborator
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
Tagging subscribers to this area: @dotnet/ncl |
stephentoub
approved these changes
Jun 25, 2020
Member
|
Thanks. |
wahmedswl
reviewed
Jun 25, 2020
| { | ||
| if (_disposed) | ||
| { | ||
| throw new ObjectDisposedException(GetType().ToString()); |
There was a problem hiding this comment.
Wouldn't be calling GetType().ToString() expensive, why not use ```typeof```` directly
Member
There was a problem hiding this comment.
GetType() will be the derived type if there is one. And while it's more expensive than a const, it pales in comparison to the cost of the exception that's about to be thrown.
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #38401