rework UseCallback_BadCertificate_ExpectedPolicyErrors test to use Loopback server to avoid external dependency#41850
Merged
wfurt merged 3 commits intodotnet:masterfrom Sep 10, 2020
Merged
Conversation
…ppbackserver to avoid external dependency
Collaborator
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
Tagging subscribers to this area: @dotnet/ncl |
ManickaP
approved these changes
Sep 4, 2020
Member
ManickaP
left a comment
ManickaP
left a comment
There was a problem hiding this comment.
Optional suggestions, otherwise LGTM.
Not a security person though.
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.ServerCertificates.cs
Show resolved
Hide resolved
Member
|
Yay for moving a test to innerloop! |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test is currently failing because new certificate on badssl.com does not have EKU so our validation throws in unexpected RemoteCertificateNameMismatch.
With this change we use loopback with certificate we can control. Since there is no external dependency, new test its no longer Outerloop.
fixes #41381