Arm: Include BBJ_ALWAYS blocks in dominance calculation

[kunalspathak]

For long time in ARM, we have a workaround to add BBJ_ALWAYS in fgEnterBlks so we do not remove that block and convert the finally into BBF_RETLESS_CALL. For that reason, we would not iterate over such blocks while computing the dominance reachability . I double checked and we have enough checks to prevent that from happening. So there is no use of special handling of this scenario during dominance calculation.

Fixes: #59298

[kunalspathak]

/azp run runtime-coreclr jitstress

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[ghost]

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

---

For long time in ARM, we have a workaround to add BBJ_ALWAYS in fgEnterBlks so we do not remove that block and convert the finally into BBF_RETLESS_CALL. For that reason, we would not iterate over such blocks while computing the dominance reachability . I double checked and we have enough checks to prevent that from happening. So there is not use of special handling of this scenario during dominance calculation where we would skip iterating these blocks leading to hitting an assert.

Fixes: #59298

Author:	kunalspathak
Assignees:	-
Labels:	area-CodeGen-coreclr
Milestone:	-

[kunalspathak]

/azp list

[azure-pipelines]

CI/CD Pipelines for this repository:

• coreclr-gc-longrunning
• coreclr-gc-simulator
• runtime-coreclr outerloop
• runtime-coreclr jitstress
• runtime-coreclr jitstressregs
• runtime-coreclr jitstress2-jitstressregs
• runtime-coreclr gcstress0x3-gcstress0xc
• runtime-coreclr gcstress-extra
• runtime-coreclr r2r-extra
• runtime-coreclr jitstress-isas-x86
• runtime-coreclr jitstress-isas-arm
• runtime-coreclr jitstressregs-x86
• runtime-coreclr libraries-jitstressregs
• runtime-coreclr libraries-jitstress2-jitstressregs
• runtime-coreclr r2r
• runtime-coreclr runincontext
• runtime-coreclr crossgen2
• runtime-libraries-coreclr outerloop
• runtime-libraries-coreclr outerloop-windows
• runtime-libraries-coreclr outerloop-linux
• runtime-libraries-coreclr outerloop-osx
• runtime
• runtime-libraries enterprise-linux
• runtime-libraries stress-http
• runtime-libraries stress-ssl
• runtime-dev-innerloop
• runtime-coreclr crossgen2 outerloop
• coreclr-release-outerloop-nightly
• sync-runtime-to-mono
• runtime-coreclr crossgen2-composite
• runtime-jit-experimental
• runtime-coreclr libraries-jitstress
• dotnet-linker-tests
• runtime-coreclr ilasm
• runtime-coreclr crossgen2-composite gcstress
• runtime-libraries-mono outerloop
• runtime-staging
• runtime-coreclr pgo
• runtime-coreclr libraries-pgo
• coreclr-gc-regions
• Antigen

[kunalspathak]

/azp run Antigen

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[kunalspathak]

/azp run runtime-coreclr jitstress

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[kunalspathak]

Failures related to #58481 and #59564

[kunalspathak]

@dotnet/jit-contrib , @BruceForstall

[BruceForstall]

I wish we could make this simpler/easier/cleaner, but for now, this LGTM.

[kunalspathak]

/azp run Antigen

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).