Fix too wide memory accesses for nullchecks#64683
Merged
EgorBo merged 16 commits intodotnet:mainfrom Feb 10, 2022
Merged
Conversation
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsFixes #64657 for now just a draft to see CI status
|
a36d4b3 to
b321357
Compare
EgorBo
commented
Feb 4, 2022
jakobbotsch
reviewed
Feb 4, 2022
Member
Author
|
@BruceForstall @jakobbotsch PTAL current version. struct Foo
{
public byte b1;
public byte b2;
}
void Test(ref Foo f)
{
var _ = f.b2; // implicit nullcheck
} |
jakobbotsch
reviewed
Feb 9, 2022
jakobbotsch
approved these changes
Feb 9, 2022
BruceForstall
approved these changes
Feb 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #64657