Skip to content

Comments

Add CentOS Stream 9 to the helix matrix#65785

Closed
omajid wants to merge 1 commit intodotnet:mainfrom
omajid:ci-add-centos-stream-9
Closed

Add CentOS Stream 9 to the helix matrix#65785
omajid wants to merge 1 commit intodotnet:mainfrom
omajid:ci-add-centos-stream-9

Conversation

@omajid
Copy link
Member

@omajid omajid commented Feb 23, 2022

No description provided.

@ghost
Copy link

ghost commented Feb 23, 2022

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Feb 23, 2022
@ghost
Copy link

ghost commented Feb 23, 2022

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: omajid
Assignees: -
Labels:

area-Infrastructure, community-contribution
Milestone: -

This was referenced Feb 23, 2022
Closed
Closed
Closed
@omajid omajid force-pushed the ci-add-centos-stream-9 branch from b4d89ba to 6548b69 Compare March 2, 2022 18:41
@runfoapp runfoapp bot mentioned this pull request Mar 2, 2022
Closed
@omajid
Copy link
Member Author

omajid commented Mar 7, 2022

A ton of errors are due to:

/root/helix/work/correlation/scripts/81e6529a566d45439877e16b740604bd/execute.sh: line 17: python: command not found

Not sure what's setting up this python; will look into it.

@hoyosjs
Copy link
Member

hoyosjs commented Mar 7, 2022

Hm. It's odd - it's supposed to come from here: https://github.com/dotnet/dotnet-buildtools-prereqs-docker/blob/b5e98ffda0465be7c51b562a97fecaae3fa32527/src/centos/stream9/Dockerfile#L43

@omajid
Copy link
Member Author

omajid commented Mar 7, 2022

Ah. CentOS Stream 9/RHEL 9's python3 package doesn't provide /usr/bin/python. Is there some way we can change this to python3? Otherwise, I guess I can update the dockerfile to install /usr/bin/python as well.

@hoyosjs
Copy link
Member

hoyosjs commented Mar 7, 2022

Not easily - those are autogenerated by helix. Maybe installing the symlink in the image feels like an easier thing? The scripts are python3 based, so that should be fairly transparent.

@omajid
Copy link
Member Author

omajid commented Mar 7, 2022

Sounds good. I was afraid it might be assuming python as being python2. I will update the dotnet dockerfiles in a bit.

omajid added a commit to omajid/dotnet-buildtools-prereqs-docker that referenced this pull request Mar 7, 2022
@omajid
Install /usr/bin/python in CentOS Stream 9
3b034ae 
Helix needs it. So, might as we install it.

See dotnet/runtime#65785
@omajid omajid mentioned this pull request Mar 7, 2022
Merged
omajid added a commit to omajid/dotnet-buildtools-prereqs-docker that referenced this pull request Mar 7, 2022
@omajid
Add helix dockerfile for CentOS Stream 9
47f6181 
Needed for runtime, eg dotnet/runtime#65785
hoyosjs
hoyosjs approved these changes Mar 7, 2022
View reviewed changes
eng/pipelines/coreclr/templates/helix-queues-setup.yml Outdated
Copy link
Member

@hoyosjs hoyosjs Mar 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- (Centos.Stream9.Amd64.Open)Ubuntu.1804.Amd64.Open@mcr.microsoft.com/dotnet-buildtools/prereqs:centos-stream9-20220107135047-4cd394c
- (Centos.Stream9.Amd64)Ubuntu.1804.Amd64@mcr.microsoft.com/dotnet-buildtools/prereqs:centos-stream9-20220107135047-4cd394c

eng/pipelines/libraries/helix-queues-setup.yml Outdated
Copy link
Member

@hoyosjs hoyosjs Mar 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd have to check, but there should be a place to add these in non-open queues so they can be tested against security releases.

eng/pipelines/coreclr/templates/helix-queues-setup.yml Outdated
Copy link
Member

@hoyosjs hoyosjs Mar 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would also duplicate testing on every PR. We usually do horizontal deployment into the platform matrix in our outer loop testing (that being said, I feel like there's nothing running tests on those other queues right now...)

@omajid omajid mentioned this pull request Apr 13, 2022
Closed
omajid added a commit to omajid/dotnet-buildtools-prereqs-docker that referenced this pull request Apr 20, 2022
@omajid
Add helix dockerfile for CentOS Stream 9
1170363 
Needed for runtime, eg dotnet/runtime#65785
omajid added a commit to omajid/dotnet-buildtools-prereqs-docker that referenced this pull request Apr 20, 2022
@omajid
Add helix dockerfile for CentOS Stream 9
4202711 
Needed for runtime, eg dotnet/runtime#65785
mthalman pushed a commit to dotnet/dotnet-buildtools-prereqs-docker that referenced this pull request Apr 21, 2022
@omajid
Add helix dockerfile for CentOS Stream 9 (#581)
dee2d19 
Needed for runtime, eg dotnet/runtime#65785
@omajid omajid marked this pull request as draft April 21, 2022 16:04
@omajid omajid force-pushed the ci-add-centos-stream-9 branch from 6548b69 to 86c292d Compare April 21, 2022 16:09
@runfoapp runfoapp bot mentioned this pull request Apr 21, 2022
Closed
@ghost ghost closed this May 21, 2022
@ghost
Copy link

ghost commented May 21, 2022

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

@ghost ghost locked as resolved and limited conversation to collaborators Jun 20, 2022
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@hoyosjs hoyosjs hoyosjs approved these changes

Assignees

No one assigned

Labels

area-Infrastructure community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@omajid @hoyosjs @teo-tsirpanis