Remove ToTimeoutSeconds.SendPingAsync and fix TimeSpan behavior#67253
Remove ToTimeoutSeconds.SendPingAsync and fix TimeSpan behavior#67253stephentoub merged 3 commits intodotnet:mainfrom
ToTimeoutSeconds.SendPingAsync and fix TimeSpan behavior#67253Conversation
To match the default behavior
Use milliseconds instead of seconds
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsAs described in #64860 (comment), this reverts the SendPingAsync overloads and further code review suggestions applied. Follow-up for #64860 - Closes #14336 /cc @danmoseley
|
|
Thanks could you please open a new issue specifically to implement the async Ping API? That will involve someone going into the ping implementation so it should be separate from #67156 |
As described in #64860 (comment), this reverts the SendPingAsync overloads and further code review suggestions applied.
Follow-up for #64860 - Closes #14336
/cc @danmoseley
/cc @stephentoub