Fix failing debug assertion in JsonTypeInfo initialization#67334
Merged
eiriktsarpalis merged 1 commit intodotnet:mainfrom Mar 30, 2022
Merged
Conversation
ghost
added
the
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis Issue DetailsFixes a failing debug assertion in what seems to be a race when multiple threads attempt to initialize the The initialization logic should be refactored so that metadata instances get initialized by a single thread, which will likely be done in conjunction with the work for #63686 cc @krwq. Fix #60962.
|
stephentoub
approved these changes
Mar 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a failing debug assertion in what seems to be a race when multiple threads attempt to initialize the
JsonTypeInfoinstance. It is likely that other initialization methods are impacted by the same issue, this PR is to unblock the CI issues as reported in #60962.The initialization logic should be refactored so that metadata instances get initialized by a single thread, which will likely be done in conjunction with the work for #63686 cc @krwq.
Fix #60962.