JIT: fix assert seen in some OSR cases#68048
Conversation
As a result of dotnet#67884, OSR compilations were looking at data in the `gsShadowVarInfo` array in cases where it was not initialized. Fix is to defer allocating the `gsShadowVarInfo` array until it's certain it will be initialized. Fixes dotnet#68003.
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsAs a result of #67884, OSR compilations were looking at data in the Fix is to defer allocating the Fixes #68003.
|
|
/azp run runtime-coreclr jitstress |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Got an OSX repro, finally. The proposed fix above is not fixing the assert. |
|
/azp run runtime-coreclr jitstress |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@BruceForstall PTAL |
BruceForstall
left a comment
BruceForstall
left a comment
There was a problem hiding this comment.
Looks like Compiler::optCopyPropPushDef() was also potentially reading an uninitialized shadowCopy field?
Yeah, I think it was... odd that that did not lead to any observable problem. |
ghost
locked as resolved and limited conversation to collaborators
2 participants
As a result of #67884, OSR compilations were looking at data in the
gsShadowVarInfoarray in cases where it was not initialized.Fix is to null out
gsShadowVarInfoarray if there are no shadowed params.Fixes #68003.