Add support for symbol stripping#70233
Conversation
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Publish.targets
Outdated
Show resolved
Hide resolved
src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.props
Outdated
Show resolved
Hide resolved
src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets
Outdated
Show resolved
Hide resolved
bedd546 to
a531506
Compare
|
How about making |
src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.props
Outdated
Show resolved
Hide resolved
src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.props
Outdated
Show resolved
Hide resolved
src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.props
Outdated
Show resolved
Hide resolved
Per @MichalStrehovsky's findings #69847 (comment), other (comparable) toolchains produce unstripped binaries by default. |
src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.props
Outdated
Show resolved
Hide resolved
|
Could you please also update https://github.com/dotnet/runtime/blob/main/src/coreclr/nativeaot/docs/optimizing.md#special-considerations-for-linuxmacos ? |
c9aad9e to
fc7aeab
Compare
src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.props
Outdated
Show resolved
Hide resolved
src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.props
Outdated
Show resolved
Hide resolved
8b0b86b to
5cf5a88
Compare
src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.props
Outdated
Show resolved
Hide resolved
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
5cf5a88 to
cca2f7e
Compare
|
@MichalStrehovsky Could you please review this as well? |
|
How is this different from setting |
The new |
|
Original size of Hello World executable on linux: 18 MB |
|
The NativeAOT leg failed because there was a Helix delay of 1 hour and 40 minutes for System.IO.FileSystem.Tests: We'll have to see if this is a pattern. Cc @LakshanF just FYI |
Usage:
Also added a fallback for compiler introspection (clang or gcc).
Fixes #69847