Fix System.Number.BigInteger.DivRem outputting an incorrect remainder

[dakersnar]

Fixes #72113

[EgorBo]

Perhaps, worth having a unit test?

[dakersnar]

@EgorBo Can do, let me try to figure out InternalsVisableTo

[stephentoub]

let me try to figure out InternalsVisableTo

We try to avoid InternalsVisibleTo, for a variety of reasons, e.g. it inhibits assembly-level trimming we do.

Why does this require internals access? If there's no way to trigger this via public surface area, I think it's fine to forego a test.

[dakersnar]

@stephentoub That makes sense. At the very least, once I merge the double to decimal conversion code, that will include a test that hits this code path. Do you think that's sufficient?

[stephentoub]

If there's no other way to trigger this bug via public surface area, sounds fine.

[azure-pipelines]

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[dakersnar]

/azp run runtime

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[ghost]

Tagging subscribers to this area: @dotnet/area-system-numerics
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Fixes #72113

Author:	dakersnar
Assignees:	dakersnar
Labels:	area-System.Numerics
Milestone:	-

[dakersnar]

@jeffhandley I think we discussed wanting to get this into 7.0. What does that process look like at this point?

[stephentoub]

I think we discussed wanting to get this into 7.0. What does that process look like at this point?

Everything going into main right now will make it into .NET 7. No additional process required (for a few more weeks).