HTTP/3 Improved message for failing QUIC connection#72374
Merged
stephentoub merged 4 commits intodotnet:mainfrom Jul 22, 2022
Merged
HTTP/3 Improved message for failing QUIC connection#72374stephentoub merged 4 commits intodotnet:mainfrom
stephentoub merged 4 commits intodotnet:mainfrom
Conversation
ghost
added
area-System.Net.Http
community-contribution
|
Tagging subscribers to this area: @dotnet/ncl |
|
|
ManickaP
removed
the
community-contribution
iuliaco
force-pushed
the
70949_uniformative_message_fix
branch
from
56d020a to
7e4737b
Compare
stephentoub
reviewed
Jul 18, 2022
src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpConnectionPool.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpConnectionPool.cs
Outdated
Show resolved
Hide resolved
Comment on lines
1290
to
1291
Contributor
Author
There was a problem hiding this comment.
Because I received "local variable added used uninitialized" type of error when both were together
Contributor
Author
There was a problem hiding this comment.
I reverted it back to the previous version
src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpConnectionPool.cs
Outdated
Show resolved
Hide resolved
iuliaco
force-pushed
the
70949_uniformative_message_fix
branch
from
8d7ce89 to
8c23157
Compare
Member
|
Failures unrelated. |
ManickaP
reviewed
Jul 19, 2022
Member
ManickaP
left a comment
ManickaP
left a comment
There was a problem hiding this comment.
Looking good. Please fix the remaining comments, I'll approve and we can merge it.
src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpConnectionPool.cs
Outdated
Show resolved
Hide resolved
CarnaViire
reviewed
Jul 19, 2022
src/libraries/System.Net.Http/tests/FunctionalTests/HttpClientHandlerTest.Http3.cs
Outdated
Show resolved
Hide resolved
CarnaViire
reviewed
Jul 19, 2022
src/libraries/System.Net.Http/tests/FunctionalTests/HttpClientHandlerTest.Http3.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Marie Píchová <11718369+ManickaP@users.noreply.github.com> Co-authored-by: Natalia Kondratyeva <knatalia@microsoft.com>
ManickaP
approved these changes
Jul 21, 2022
Member
ManickaP
left a comment
ManickaP
left a comment
There was a problem hiding this comment.
Looks good, let's wait for the CI to run the tests and then we can merge 🥳
CarnaViire
reviewed
Jul 21, 2022
src/libraries/System.Net.Http/tests/FunctionalTests/HttpClientHandlerTest.Http3.cs
Outdated
Show resolved
Hide resolved
…HandlerTest.Http3.cs Co-authored-by: Natalia Kondratyeva <knatalia@microsoft.com>
stephentoub
approved these changes
Jul 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #70949