Skip to content

Comments

JIT: Avoid using type info from GDV guesses during import#72376

Merged
jakobbotsch merged 2 commits intodotnet:mainfrom
jakobbotsch:fix-72363
Jul 19, 2022
Merged

JIT: Avoid using type info from GDV guesses during import#72376
jakobbotsch merged 2 commits intodotnet:mainfrom
jakobbotsch:fix-72363

Conversation

@jakobbotsch
Copy link
Member

@jakobbotsch jakobbotsch commented Jul 18, 2022

We can only use this type information after they have been expanded and
if we are on the happy path.

Fix #72363

@jakobbotsch
JIT: Avoid using type info from GDV guesses during import
b901515 
We can only use this type information after they have been expanded and
if we are on the happy path.

Fix dotnet#72363
@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jul 18, 2022
@ghost ghost assigned jakobbotsch Jul 18, 2022
@ghost
Copy link

ghost commented Jul 18, 2022

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

We can only use this type information after they have been expanded and
if we are on the happy path.

Fix #72363

Author: jakobbotsch
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

@jakobbotsch
Copy link
Member Author

jakobbotsch commented Jul 18, 2022

Covariant returns would have the same problem but resolveVirtualMethod currently fails for them with CORINFO_DEVIRTUALIZATION_FAILED_SLOT, so I think generics is the only case we can see this.

@jakobbotsch
Copy link
Member Author

jakobbotsch commented Jul 18, 2022

cc @dotnet/jit-contrib PTAL @AndyAyersMS @EgorBo

AndyAyersMS
AndyAyersMS approved these changes Jul 18, 2022
View reviewed changes
Copy link
Member

@AndyAyersMS AndyAyersMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bug is also in 6.0, right?

We should consider porting the fix there.

@jakobbotsch
Copy link
Member Author

jakobbotsch commented Jul 18, 2022

This bug is also in 6.0, right?

Doesn't look like it, we don't manage to do GDV for the test in 6.0. Looks like #56254 added that support.

@jakobbotsch
Copy link
Member Author

jakobbotsch commented Jul 18, 2022

The bug might exist in 6.0 R2R though, IIUC that worked before #56254.

@runfoapp runfoapp bot mentioned this pull request Jul 19, 2022
Closed
@jakobbotsch
Copy link
Member Author

jakobbotsch commented Jul 19, 2022

The failure is #72429.

I'll choose not to backport this given the above.

@jakobbotsch jakobbotsch merged commit 2f5606d into dotnet:main Jul 19, 2022
@jakobbotsch jakobbotsch deleted the fix-72363 branch July 19, 2022 14:54
@runfoapp runfoapp bot mentioned this pull request Jul 19, 2022
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AndyAyersMS AndyAyersMS AndyAyersMS approved these changes

Assignees

@jakobbotsch jakobbotsch

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[libraries-pgo] NRE in System.Collections.Immutable.Tests.ImmutableArrayBuilderTest.IndexOf

2 participants

@jakobbotsch @AndyAyersMS