Skip to content

Comments

increase timeout on ZeroByteRead_IssuesZeroByteReadOnUnderlyingStream test#73196

Merged
wfurt merged 3 commits intodotnet:mainfrom
wfurt:zeroRead
Aug 4, 2022
Merged

increase timeout on ZeroByteRead_IssuesZeroByteReadOnUnderlyingStream test#73196
wfurt merged 3 commits intodotnet:mainfrom
wfurt:zeroRead

Conversation

@wfurt
Copy link
Member

@wfurt wfurt commented Aug 1, 2022

fixes #67509

I saw occasional local failures on my Win11 machine. I did not see failure since I increased the timeout.
Not that PassingTestTimeoutMilliseconds is 60s for HTTP. I could possibly use that instead but the 30s is holding so far for me.

@wfurt wfurt added this to the 7.0.0 milestone Aug 1, 2022
@wfurt wfurt requested a review from a team August 1, 2022 23:38
@wfurt wfurt self-assigned this Aug 1, 2022
@ghost
Copy link

ghost commented Aug 1, 2022

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

fixes #67509

I saw occasional local failures on my Win11 machine. I did not see failure since I increased the timeout.
Not that PassingTestTimeoutMilliseconds is 60s for HTTP. I could possibly use that instead but the 30s is holding so far for me.

Author: wfurt
Assignees: wfurt
Labels:

area-System.Net.Http

Milestone: 7.0.0

@stephentoub
Copy link
Member

Not that PassingTestTimeoutMilliseconds is 60s for HTTP. I could possibly use that instead but the 30s is holding so far for me.

There's little harm in using a longer timeout... it's only problematoc when the test fails. My preference would be to just use the existing named constant.

@karelz
Copy link
Member

karelz commented Aug 4, 2022

@stephentoub can you please approve? (assuming it is now ok) Thanks!

@wfurt wfurt merged commit cc4dadd into dotnet:main Aug 4, 2022
@wfurt wfurt deleted the zeroRead branch August 4, 2022 22:47
@ghost ghost locked as resolved and limited conversation to collaborators Sep 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

timeout in ZeroByteRead_IssuesZeroByteReadOnUnderlyingStream

5 participants