increase timeout on ZeroByteRead_IssuesZeroByteReadOnUnderlyingStream test#73196
Merged
wfurt merged 3 commits intodotnet:mainfrom Aug 4, 2022
Merged
increase timeout on ZeroByteRead_IssuesZeroByteReadOnUnderlyingStream test#73196wfurt merged 3 commits intodotnet:mainfrom
wfurt merged 3 commits intodotnet:mainfrom
Conversation
|
Tagging subscribers to this area: @dotnet/ncl Issue Detailsfixes #67509 I saw occasional local failures on my Win11 machine. I did not see failure since I increased the timeout.
|
Member
There's little harm in using a longer timeout... it's only problematoc when the test fails. My preference would be to just use the existing named constant. |
CarnaViire
reviewed
Aug 2, 2022
src/libraries/System.Net.Http/tests/FunctionalTests/ResponseStreamZeroByteReadTests.cs
Outdated
Show resolved
Hide resolved
Member
|
@stephentoub can you please approve? (assuming it is now ok) Thanks! |
MihaZupan
approved these changes
Aug 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #67509
I saw occasional local failures on my Win11 machine. I did not see failure since I increased the timeout.
Not that
PassingTestTimeoutMillisecondsis 60s for HTTP. I could possibly use that instead but the 30s is holding so far for me.