Work around invalid IR with field morphing temps#77848
Merged
AndyAyersMS merged 2 commits intodotnet:mainfrom Nov 4, 2022
Merged
Work around invalid IR with field morphing temps#77848AndyAyersMS merged 2 commits intodotnet:mainfrom
AndyAyersMS merged 2 commits intodotnet:mainfrom
Conversation
ghost
added
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsCreate unique temps for the case that can run into issues. Fixes #77773. Q: what makes these morphing temps so special we are only now running into issues with them?
|
To avoid running into invalid IR issues.
SingleAccretion
force-pushed
the
Zero-Offset-Null-Check-Temps-Upstream
branch
from
41123f9 to
873faae
Compare
This was referenced Nov 4, 2022
Contributor
Author
|
Failures are known according to build analysis. @dotnet/jit-contrib |
AndyAyersMS
approved these changes
Nov 4, 2022
Member
AndyAyersMS
left a comment
AndyAyersMS
left a comment
There was a problem hiding this comment.
Was going to suggest you might consider adopting the same sort of logic the importer uses to reuse box temps. But currently does not seem to be not worth the trouble.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create unique temps for the case that can run into issues.
Fixes #77773.
Q: what makes these morphing temps so special we are only now running into issues with them?
A: they are quite unique in that they're multi-use, multi-def, and both uses and defs can appear in arbitrary places.
Diffs.