fuse < and > with = when applicable#78786
Conversation
ghost
added
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsFixes #78385
|
|
@EgorBo PTAL |
|
@pedrobsaila could you please merge/rebase recent Main into your PR so we can get the recent diffs? |
|
/azp run Fuzzlyn |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@pedrobsaila sorry for the delay, overall looks good to me, can you rebase it once again please? |
|
/azp run Fuzzlyn |
|
Commenter does not have sufficient privileges for PR 78786 in repo dotnet/runtime |
|
Ping @EgorBo for one more review. |
|
@pedrobsaila, please resolve the conflict. |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
EgorBo
left a comment
EgorBo
left a comment
There was a problem hiding this comment.
Sorry for the long delay - LGTM, I see that we can check LCL_VAR by its num here since both blocks are expected to be single-statement and there should be no COMMAs or other ways to modify the value (in the common case, just checking numbers doesn't mean they're the same). I think it's good as is, but I'll file a PR to clean up this phase a bit, e.g. move these rules to a sort of macros-based table
|
@EgorBo should we merge this? |
5 participants
Fixes #78385