Add mechanism for runtime to query host for information#78798
Merged
elinor-fung merged 5 commits intodotnet:mainfrom Dec 6, 2022
Merged
Add mechanism for runtime to query host for information#78798elinor-fung merged 5 commits intodotnet:mainfrom
elinor-fung merged 5 commits intodotnet:mainfrom
Conversation
|
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov Issue Detailsnull
|
elinor-fung
commented
Nov 24, 2022
1e0983a to
4e6645c
Compare
vitek-karas
reviewed
Nov 24, 2022
Member
Author
vitek-karas
approved these changes
Dec 2, 2022
Member
vitek-karas
left a comment
There was a problem hiding this comment.
I like this 😄
Just the minor comment about priority of the properties, otherwise looks great.
src/installer/tests/Assets/TestProjects/HostApiInvokerApp/HostRuntimeContract.cs
Show resolved
Hide resolved
vitek-karas
approved these changes
Dec 5, 2022
Member
|
Would be good to add a short description of this into the docs in the repo - along with "why are we doing this" and "how we see it being used in the future"... and finally "this is the future way of passing more properties to the runtime". Basically document the decisions and design - doesn't have to be long, it's pretty simple at the end. |
This was referenced Dec 6, 2022
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass a struct from the host to the runtime as a new property
HOST_RUNTIME_CONTRACT. The runtime can use this to query for information from the host.get_runtime_property: get the value of a property from the host. The host's current implementation just handles the same properties given to the runtime on initialization. It can be updated to handle/compute additional information on-demand as the need arises.bundle_probe: existing function used for single-filepinvoke_override: existing function used for single-fileThe struct can be extended in the future to handle more specific/structured information in a nicer way than property strings (for example separate function to get or enumerate the TPA / probing paths).
Resolves #77458