Add .NET 7 source gen regression tests#78857
Merged
eiriktsarpalis merged 1 commit intodotnet:mainfrom Nov 30, 2022
Merged
Conversation
ghost
added
the
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis Issue DetailsFollowing up on #71850 this PR adds regression tests locked to code generated via the .NET 7 sdk. Repo used for generating code can be found here: https://github.com/eiriktsarpalis/stj-regressionsuite
|
layomia
approved these changes
Nov 28, 2022
| TypeInfoResolver = JsonTypeInfoResolver.Combine(Net70GeneratedContext.Default, new DefaultJsonTypeInfoResolver()) | ||
| }; | ||
|
|
||
| // Unlike v6, v7 Contexts do implement IJsonTypeInfoResolver so combined resolvers will produce the expected output. |
Contributor
There was a problem hiding this comment.
The other tests are identical. Should we have an abstraction?
Member
Author
There was a problem hiding this comment.
They actually differ in a few places, so I don't think DRY would help a lot here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up on #71850 this PR adds regression tests locked to code generated via the .NET 7 sdk. Repo used for generating code can be found here: https://github.com/eiriktsarpalis/stj-regressionsuite