[mono][interp] Replace ldobj.vt + stobj.vt.noref pair with cpobj.vt.noref#79302
Merged
BrzVlad merged 2 commits intodotnet:mainfrom Dec 7, 2022
Merged
[mono][interp] Replace ldobj.vt + stobj.vt.noref pair with cpobj.vt.noref#79302BrzVlad merged 2 commits intodotnet:mainfrom
BrzVlad merged 2 commits intodotnet:mainfrom
Conversation
ghost
added
the
|
Tagging subscribers to this area: @BrzVlad Issue DetailsThis avoids redundant copying to interpreter stack.
|
vargaz
approved these changes
Dec 6, 2022
Member
|
the wasm build test failures are known and not related |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids redundant copying to interpreter stack. Pattern typically used in copying data, as in
Buffer.Memmove(where this provides over 5% speedup).