Merged
Conversation
We no longer need cheap preds. We always have full preds available. Also, remove the ability to drop and recompute full preds, as we now compute full preds incrementally while building the flow graph, and never drop or need to rebuild them. Contributes to dotnet#80193.
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak Issue DetailsWe no longer need cheap preds. We always have full preds available. Also, remove the ability to drop and recompute full preds, as we now compute full preds incrementally while building the flow graph, and never drop or need to rebuild them. Contributes to #80193.
|
Member
Author
|
@EgorBo PTAL (or @BruceForstall who I think was responsible for cheap preds). CC @dotnet/jit-contrib No diffs expected. |
Member
Author
|
arm SPMI timed out, will retry that bit. |
EgorBo
approved these changes
Feb 3, 2023
This was referenced Feb 3, 2023
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We no longer need cheap preds. We always have full preds available.
Also, remove the ability to drop and recompute full preds, as we now compute full preds incrementally while building the flow graph, and never drop or need to rebuild them.
Contributes to #80193.