JIT: rename flowList to FlowEdge and encapsulate all fields#81621
Merged
AndyAyersMS merged 1 commit intodotnet:mainfrom Feb 7, 2023
Merged
JIT: rename flowList to FlowEdge and encapsulate all fields#81621AndyAyersMS merged 1 commit intodotnet:mainfrom
AndyAyersMS merged 1 commit intodotnet:mainfrom
Conversation
Restructure this type in anticipation of modifying how it represents data. Rename some of the fields (and now related accessor methods) because subsequent changes may do things like add the target block or successor edge links. Also, remove some stray references to fgComputePreds
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak Issue DetailsRestructure this type in anticipation of modifying how it represents data. Rename some of the fields (and now related accessor methods) because subsequent changes may do things like add the target block or successor edge links. Also, remove some stray references to fgComputePreds
|
Member
Author
|
@TIHan PTAL Largely mechanical renaming/reformatting. Should be no diff. |
44 tasks
BruceForstall
approved these changes
Feb 6, 2023
| FlowEdge* const newEdge = fgAddRefPred(newTarget, blockSwitch); | ||
|
|
||
| // Now set the correct value of newEdge->flDupCount | ||
| // Now set the correct value of newEdge's lDupCount |
Contributor
There was a problem hiding this comment.
nit: DupCount? or m_dupCount?
Member
Author
There was a problem hiding this comment.
Oops. Will fix this as part of an upcoming PR.
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restructure this type in anticipation of modifying how it represents data. Rename some of the fields (and now related accessor methods) because subsequent changes may do things like add the target block or successor edge links.
Also, remove some stray references to fgComputePreds