[wasm] Add narrow methods to PackedSimd#83084
Merged
radekdoulik merged 2 commits intodotnet:mainfrom Mar 7, 2023
Merged
Conversation
Add them as internal as the approved API contains wrong methods for these. dotnet#53730 (comment) This will allow faster implementation of IndexOfAnyValues for wasm. dotnet#82789 (comment)
|
Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics Issue DetailsAdd them as internal as the approved API contains wrong methods for these. #53730 (comment) This will allow faster implementation of IndexOfAnyValues for wasm. #82789 (comment)
|
Member
Author
|
As the documentation is a bit unclear (the text and binary format parts could be explained differently about the inputs), I checked the results with this test, running with node. It looks like the inputs are indeed treated as signed integers here. |
Member
Author
|
The relevant code from the test above: |
vargaz
approved these changes
Mar 7, 2023
Member
Author
|
The failing builds are unrelated |
This was referenced Mar 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add them as internal as the approved API contains wrong methods for these. #53730 (comment)
This will allow faster implementation of IndexOfAnyValues for wasm. #82789 (comment)