Fix superpmi unit test on Alpine#83372
Conversation
`perl` was removed from the Alpine images we use. The superpmi unit test harness was using `perl` to convert the line endings in the superpmicollect.sh wrapper script harness from Windows CR/LF format to Linux/Mac LF format. It appears this is no longer necessary, as the wrapper scripts appear to be built in CI during the "Generate tests wrappers" step on Linux when they will be run on Linux, so they already have the correct line endings. Remove the call to invoke `perl`. Fixes dotnet#83320
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak Issue Details
It appears this is no longer necessary, as the wrapper scripts appear to be built in CI during the "Generate tests wrappers" step on Linux when they will be run on Linux, so they already have the correct line endings. Remove the call to invoke Fixes #83320
|
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@jakobbotsch If you see/review/approve this, and outerloop passes (or at least doesn't fail on the superpmi unit test), please merge. |
|
Failure is #83298 |
ghost
locked as resolved and limited conversation to collaborators
2 participants
perlwas removed from the Alpine images we use. The superpmi unit test harness was usingperlto convert the line endings in the superpmicollect.sh wrapper script harness from Windows CR/LF format to Linux/Mac LF format.It appears this is no longer necessary, as the wrapper scripts appear to be built in CI during the "Generate tests wrappers" step on Linux when they will be run on Linux, so they already have the correct line endings. Remove the call to invoke
perl.Fixes #83320