Add references to xunit.*.dll to CLRTest.Crossgen.targets#83413
Add references to xunit.*.dll to CLRTest.Crossgen.targets#83413trylek merged 1 commit intodotnet:mainfrom
Conversation
This change fixes the exceptions thrown from Crossgen2 JIT interface when JIT tries to resolve tokens from xunit.assert. As a secondary effect the frequent exception throws triggered the race condition dotnet#81884 triggering non-deterministic native CoreCLR runtime failures on arm64. I was originally reluctant to fix this primary issue until the native runtime bug is understood as otherwise this fix would just cause the issue to stop manifesting without being actually fixed. As the runtime bug has been fixed by now, I am fixing Crossgen2 executions to stop hitting these resolution exceptions. Thanks Tomas
|
Tagging subscribers to this area: @hoyosjs Issue DetailsThis change fixes the exceptions thrown from Crossgen2 JIT interface when JIT tries to resolve tokens from xunit.assert. As a secondary effect the frequent exception throws ended up hitting the race condition triggering non-deterministic native CoreCLR runtime failures on arm64. I was reluctant to fix this primary issue until the native runtime bug is understood as otherwise this fix would just cause the issue to stop manifesting without being actually fixed. As the runtime bug has been fixed by now, I am fixing Crossgen2 executions to stop hitting these resolution exceptions. Thanks Tomas Mitigates: #81120, #77820, #81109 /cc @dotnet/crossgen-contrib
|
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
The only failures in the outerloop runs are the known HardwareIntrinsics_ro timeouts, merging in. |
|
Thanks @trylek for the fix!! |
ghost
locked as resolved and limited conversation to collaborators
5 participants
This change fixes the exceptions thrown from Crossgen2 JIT interface when JIT tries to resolve tokens from xunit.assert. As a secondary effect the frequent exception throws ended up hitting the race condition
#81884
triggering non-deterministic native CoreCLR runtime failures on arm64. I was reluctant to fix this primary issue until the native runtime bug is understood as otherwise this fix would just cause the issue to stop manifesting without being actually fixed. As the runtime bug has been fixed by now, I am fixing Crossgen2 executions to stop hitting these resolution exceptions.
Thanks
Tomas
Mitigates: #81120, #77820, #81109
/cc @dotnet/crossgen-contrib