Conversation
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak Issue DetailsAt this point, both There will be a follow-up which similarly unifies
|
1aa3b80 to
1383ff5
Compare
|
@dotnet/jit-contrib |
983db5d to
6ba7292
Compare
GT_OBJ and GT_OBJ both represent struct loads. There is no need to have two. Delete GT_OBJ as the more derived one.
6ba7292 to
172bd11
Compare
172bd11 to
c0fbd99
Compare
|
@SingleAccretion can you resolve the conflicts? |
|
@dotnet/jit-contrib anyone planning on reviewing this one? I will take a look if there are not volunteers. |
| blkNode->gtFlags |= indirFlags; | ||
| blkNode->SetIndirExceptionFlags(this); | ||
|
|
||
| // TODO-Bug: this method does not have enough information to make this determination. |
There was a problem hiding this comment.
Is there a follow-up issue for this?
There was a problem hiding this comment.
I see that comment just migrated here from the former OBJ case.
- Failed due to dotnet#84221
At this point, both
GT_BLKandGT_OBJrepresent struct loads and are essentially identical in purpose (if not functionality). This change unifies the two asGT_BLK, though I am naturally open to going the other way or choosing a different oper name altogether.There will be a follow-up which similarly unifies
STORE_BLKwithSTORE_OBJ.Diffs: one CSE due to the change in
gtSetEvalOrder.A bit of a TP regression on 64 bit because MSVC doesn't inline
gtIsLikelyRegVarin the same function, and some perturbance in theswitchoffgComputeLifeLIR.TP breakdown