[JIT] ARM64 - Combine cmp and shift ops into a single cmp op#84605
Merged
TIHan merged 8 commits intodotnet:mainfrom Apr 17, 2023
Merged
[JIT] ARM64 - Combine cmp and shift ops into a single cmp op#84605TIHan merged 8 commits intodotnet:mainfrom
cmp and shift ops into a single cmp op#84605TIHan merged 8 commits intodotnet:mainfrom
Conversation
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak Issue DetailsDescriptionGive this example: lsl w1, w1, #2
cmp w0, w1Can be converted into a single cmp w0, w1, LSL #2This PR will not include the
|
Contributor
Author
|
@dotnet/jit-contrib @BruceForstall @tannergooding This is ready. CI linux formatting failure is unrelated. |
Contributor
Author
29 tasks
Comment on lines
+10337
to
+10338
| NO_WAY("expected a shift-op"); | ||
| return INS_OPTS_NONE; |
Member
There was a problem hiding this comment.
Should this stay unreached()?
Contributor
Author
There was a problem hiding this comment.
Shouldn't matter as long as something fails; also the NO_WAY is more descriptive. There are similar functions doing this.
tannergooding
approved these changes
Apr 13, 2023
This was referenced Apr 20, 2023
Closed
3 tasks
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Given this example:
Can be converted into a single
cmp:This PR will not include the
cmnversion.