Add internal Encoding.TryGetBytes#84609
Merged
stephentoub merged 1 commit intodotnet:mainfrom Apr 11, 2023
Merged
Conversation
|
Tagging subscribers to this area: @dotnet/area-system-text-encoding Issue DetailsContributes to #84425 The above issue is about adding this as a public API to Encoding. For now, so we can use it from at least Utf8.TryWrite, I'm adding it as internal. Having the UTF8EncodingSealed stub in place will also unblock @EgorBo to make it an intrinsic, which will enable the literal portions of those strings to be encoded at JIT compile time rather than on each execution.
|
GrabYourPitchforks
approved these changes
Apr 11, 2023
Member
|
/cc @tarekgh for awareness in case you think it's worth updating System.Text.Encoding.Extensions in the future. |
Member
|
Improvements on arm64: |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #84425
The above issue is about adding this as a public API to Encoding. For now, so we can use it from at least Utf8.TryWrite, I'm adding it as internal. Having the UTF8EncodingSealed stub in place will also unblock @EgorBo to make it an intrinsic, which will enable the literal portions of those strings to be encoded at JIT compile time rather than on each execution.