Fix for test build break in the outerloop pipeline#84649
Merged
kunalspathak merged 1 commit intodotnet:mainfrom Apr 12, 2023
Merged
Fix for test build break in the outerloop pipeline#84649kunalspathak merged 1 commit intodotnet:mainfrom
kunalspathak merged 1 commit intodotnet:mainfrom
Conversation
The PR dotnet#84383 missed one case that is now causing build errors in the Pri1 test suite. I have attempted to fix this along the lines of the above PR. Thanks Tomas
ghost
assigned
Member
Author
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
7 tasks
Member
Author
|
Fixing the primary test build break uncovered a secondary bug on Windows arm in the |
BruceForstall
approved these changes
Apr 11, 2023
MichalStrehovsky
approved these changes
Apr 12, 2023
Member
MichalStrehovsky
left a comment
MichalStrehovsky
left a comment
There was a problem hiding this comment.
We'll be able to delete this code because IsNotSerialized is now unused, but that can be done later.
Contributor
|
Failure is #84462 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR
#84383
missed one case that is now causing build errors in the Pri1 test suite. I have attempted to fix this along the lines of the above PR.
Thanks
Tomas
/cc @dotnet/crossgen-contrib, @dotnet/ilc-contrib
Example run:
https://dev.azure.com/dnceng-public/public/_build/results?buildId=234211&view=logs&j=3725811e-4a8b-5f6a-b03b-a353ee894148&t=d59fccfb-2b13-5841-75bf-bfec705ee16a
Diagnostics:
Lib -> /__w/1/s/artifacts/tests/coreclr/AnyOS.x64.Checked/Loader/classloader/generics/Variance/Delegates/Lib/Lib.dll /__w/1/s/src/coreclr/tools/Common/TypeSystem/Ecma/EcmaField.cs(150,40): error SYSLIB0050: 'FieldAttributes.NotSerialized' is obsolete: 'Formatter-based serialization is obsolete and should not be used.' [/__w/1/s/src/tests/ilverify/ILVerificationTests.csproj] [/__w/1/s/src/tests/build.proj] ##[error]src/coreclr/tools/Common/TypeSystem/Ecma/EcmaField.cs(150,40): error SYSLIB0050: 'FieldAttributes.NotSerialized' is obsolete: 'Formatter-based serialization is obsolete and should not be used.' [/__w/1/s/src/tests/ilverify/ILVerificationTests.csproj] Lib -> /__w/1/s/artifacts/tests/coreclr/AnyOS.x64.Checked/Loader/classloader/generics/Variance/IL/Lib/Lib.dll