Skip to content

Comments

Always set GTF_GLOB_REF on block indirs#84731

Merged
EgorBo merged 1 commit intodotnet:mainfrom
SingleAccretion:Blk-Glob-Ref
Apr 13, 2023
Merged

Always set GTF_GLOB_REF on block indirs#84731
EgorBo merged 1 commit intodotnet:mainfrom
SingleAccretion:Blk-Glob-Ref

Conversation

@SingleAccretion
Copy link
Contributor

@SingleAccretion SingleAccretion commented Apr 12, 2023

Eventually, this logic will be shared by all indirs.

No diffs.

Eventually, this logic will be shared by all indirs.
@ghost ghost added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member labels Apr 12, 2023
@ghost
Copy link

ghost commented Apr 12, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak
See info in area-owners.md if you want to be subscribed.

Issue Details

Eventually, this logic will be shared by all indirs.

No diffs are expected.

Author: SingleAccretion
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

@SingleAccretion
Copy link
Contributor Author

Formatting failure is #84780.

No diffs.

@dotnet/jit-contrib

@SingleAccretion SingleAccretion marked this pull request as ready for review April 13, 2023 15:43
Copy link
Member

@EgorBo EgorBo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@EgorBo EgorBo merged commit 926062a into dotnet:main Apr 13, 2023
@SingleAccretion SingleAccretion deleted the Blk-Glob-Ref branch April 19, 2023 20:25
@ghost ghost locked as resolved and limited conversation to collaborators May 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants