Skip to content

Comments

Disable TLS field access for Arm#84954

Merged
kunalspathak merged 5 commits intodotnet:mainfrom
kunalspathak:tls-arm
Apr 18, 2023
Merged

Disable TLS field access for Arm#84954
kunalspathak merged 5 commits intodotnet:mainfrom
kunalspathak:tls-arm

Conversation

@kunalspathak
Copy link
Contributor

TEB on Arm32 is accessed using co-processor registers and today we do not support them, or the instructions needed for them. Disable TLS access for Arm32.

Fixes: #84818

References:

@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 17, 2023
@kunalspathak
Copy link
Contributor Author

/azp run runtime-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kunalspathak
Copy link
Contributor Author

kunalspathak commented Apr 18, 2023

I am trying to revert #84943 and see if outerloop is clean for windows-arm.
cc: @trylek

@kunalspathak
Copy link
Contributor Author

/azp run runtime-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kunalspathak
Copy link
Contributor Author

@trylek - Looks like all the issues are fixed with this.

Copy link
Member

@trylek trylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks Kunal for fixing this!

@kunalspathak kunalspathak merged commit 9314a38 into dotnet:main Apr 18, 2023
@kunalspathak kunalspathak deleted the tls-arm branch April 18, 2023 23:28
@ghost ghost locked as resolved and limited conversation to collaborators May 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Intermittent failure in JIT/Directed/coverage/oldtests/tlstest_il_r/tlstest.dll

3 participants