Multiple GDV: ignore non-inlineable candidates#86835
Merged
EgorBo merged 2 commits intodotnet:mainfrom May 27, 2023
Merged
Conversation
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsContributes to #86769 The current logic used to give on all of them if at least one of the candidates were non inlineable (for any reason) public interface IValue
{
int GetValue();
}
public class MyClass1 : IValue
{
public int GetValue() => 10;
}
public class MyClass2 : IValue
{
[MethodImpl(MethodImplOptions.NoInlining)]
public int GetValue() => 50;
}
public class MyClass3 : IValue
{
public int GetValue() => 100;
}
|
14 tasks
EgorBo
commented
May 27, 2023
Member
Author
|
@AndyAyersMS PTAL |
AndyAyersMS
reviewed
May 27, 2023
Member
Author
|
@AndyAyersMS Thanks! Good idea, not sure why I decided to introduce those struct copies. Addressed via 2d3395e - it also simplified the code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #86769
The current logic used to give up on all of them if at least one of the candidates was non-inlineable (for any reason)
E.g.:
Was:
Now: